-
Notifications
You must be signed in to change notification settings - Fork 705
Feat:somark plugins #2487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat:somark plugins #2487
The head ref may contain hidden characters: "feat\uFF1Asomark-plugins"
Conversation
Summary of ChangesHello @Soul-Code, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the Somark DocAI platform as a new plugin within Dify, significantly enhancing its document processing capabilities. Users can now convert diverse document types, such as PDFs and images, into structured Markdown or JSON outputs. This integration provides advanced document understanding and data extraction, facilitating the incorporation of document content into LLM training, RAG systems, and intelligent agents. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new somark plugin, which is a great addition. The code is well-structured, but I've found a few issues that should be addressed before merging. These include a critical bug in API URL construction, missing credential validation, potential runtime errors, and several inconsistencies in metadata and documentation. Addressing these points will improve the plugin's robustness and user experience.
crazywoola
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
Add Somark tool plugin for converting documents (PDFs, images, etc.) into structured Markdown or JSON format using the Somark API. Features: - Document extraction with OXR (Optical Everything Recognition) algorithm - Support for multiple file formats (PDF, PNG, JPG, etc.) - Configurable API endpoint and authentication - Max file size: 50MB/50 pages
1. Improve error handling and type hinting in extract tool 2. Add credential validation in provider 3. Ensure icon resource exists
c46703a to
ca66061
Compare
|
Hi @crazywoola, Thanks for the review! I've addressed all your comments. Please take another look when you have a chance. |
Add Somark tool plugin for converting documents (PDFs, images, etc.) into structured Markdown or JSON format using the Somark API.
Features:
Document extraction with OXR (Optical Everything Recognition) algorithm
Support for multiple file formats (PDF, PNG, JPG, etc.)
Configurable API endpoint and authentication
Max file size: 50MB/50 pages
Related Issues or Context
This PR contains Changes to Non-Plugin
This PR contains Changes to Non-LLM Models Plugin
This PR contains Changes to LLM Models Plugin
Version Control (Any Changes to the Plugin Will Require Bumping the Version)
VersionField, Not in Meta Section)Dify Plugin SDK Version
dify_plugin>=0.3.0,<0.6.0is in requirements.txt (SDK docs)Environment Verification (If Any Code Changes)
Local Deployment Environment
SaaS Environment